RFR: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main

[Alexander Zvegintsev]

On Thu, 14 Mar 2024 16:40:56 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main using PassFailJFrame

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 67:

> 65:             .rows(15)
> 66:             .columns(40)
> 67:             .testUI(new MemoryLeak())

It currently creates the MemoryLeak(aka Frame) on the main thread, instead of EDT.

Suggestion:

            .testUI(MemoryLeak::new)

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 73:

> 71:         if (Globals.mainThread != null) {
> 72:             Globals.mainThread.interrupt();
> 73:         }

Not sure why do we need this.

test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 77:

> 75:             Thread.sleep(300000);
> 76:         } catch (InterruptedException e) {
> 77:             if (!Globals.testPassed) {

It looks like `Globals.testPassed` is never changed, so the test will always fail.
Shouldn't this be controlled by the PassFailJFrame Pass/Fail buttons?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1525764471
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1525768022
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1525768354