RFR: 8328242: Add a log area to the PassFailJFrame [v2]
Alexey Ivanov
aivanov at openjdk.org
Fri Mar 15 15:16:41 UTC 2024
On Fri, 15 Mar 2024 14:59:07 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> This doesn't look good to me
>> 
>>
>> So how about a placeholder text? It will not take up any of the height of the window.
>>
>> 
>
> I expected the label to be aligned to the left. For this to happen, the label may need to wrapped into another panel or horizontal box with added glue.
>
>
>
> Box logLabelBox = Box.createHorizontalBox();
> logLabelBox.add(new JLabel("Log:"));
> logLabelBox.add(Box.createHorizontalGlue());
>
> Box buttonsLogPanel = Box.createVerticalBox();
> buttonsLogPanel.add(buttonsPanel);
> buttonsLogPanel.add(logLabelBox);
> buttonsLogPanel.add(new JScrollPane(logArea));
>
>
> 
>
> Placeholder text isn't supported by Swing natively, is it? Therefore, you'll have to remove the placeholder text when you add the first message, which complicates logging a message.
It could be obvious from the usage… so we may skip the header altogether… if it's mentioned in the instructions, which should still be mentioned to let the test know they need to look for the messages.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18319#discussion_r1526425332
More information about the client-libs-dev
mailing list