RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v3]

Andrey Turbanov aturbanov at openjdk.org
Sat Mar 16 22:34:25 UTC 2024


On Sat, 16 Mar 2024 09:36:57 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> This test is converted to main using PassFailJFrame. It verifies wheel rotation value for high-res mouse on windows.
>> 
>> The test requires the updated PassFailJFrame's logArea() feature added in this PR https://github.com/openjdk/jdk/pull/18319
>
> Harshitha Onkar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - used PassFailJFrame.logArea()
>  - Merge branch 'master' into WheelRotation_8328190
>  - ordering of imports
>  - whitespace removed
>  - default timeout used
>  - @requires tag
>  - title change
>  - converted test to main
>  - delete .html file
>  - moved test file

test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 71:

> 69:         panel.setBackground(Color.GREEN);
> 70:         panel.addMouseWheelListener(e -> PassFailJFrame.log(e.toString()));
> 71:         frame.setSize (200,200);

Suggestion:

        frame.setSize(200, 200);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1527142345


More information about the client-libs-dev mailing list