RFR: 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main [v2]

Abhishek Kumar abhiscxk at openjdk.org
Mon Mar 18 08:27:32 UTC 2024


On Mon, 18 Mar 2024 03:00:49 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Converted to a main manual test.
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixes based on review feedback

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 37:

> 35:  * @test
> 36:  * @bug 8007155
> 37:  * @summary [macosx] Disabled panel takes mouse input in JLayeredPane

Is the test exclusive for MacOS?

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 41:

> 39:  * @build PassFailJFrame
> 40:  * @run main/manual CursorOverlappedPanelsTest
> 41:  */

May add a blank line after this.

test/jdk/java/awt/Cursor/CursorOverlappedPanelsTest.java line 45:

> 43:     public static JFrame initialize() {
> 44:         final JFrame frame = new JFrame("Overlapping Panels Cursor Test");
> 45:         frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE); redundant, can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528053426
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528052078
PR Review Comment: https://git.openjdk.org/jdk/pull/18331#discussion_r1528050661


More information about the client-libs-dev mailing list