RFR: 8327840: Automate javax/swing/border/Test4129681.java [v2]

Tejesh R tr at openjdk.org
Mon Mar 18 09:50:43 UTC 2024


On Mon, 18 Mar 2024 08:04:36 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Tejesh R has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review updates
>
> test/jdk/javax/swing/border/Test4129681.java line 62:
> 
>> 60:         label.setSize(SIZE);
>> 61:         label.setEnabled(false);
>> 62:         BufferedImage image = new BufferedImage((int) Math.ceil(label.getWidth()),
> 
> It can be - 
> BufferedImage(label.getWidth(), label.getHeight(),
>                 TYPE_INT_RGB);
> 
> Why Math.ceil is required ?

Removed.

> test/jdk/javax/swing/border/Test4129681.java line 79:
> 
>> 77:         }
>> 78: 
>> 79:         if (((double)correctColoredPixels/totalPixels*100) <= tolerance) {
> 
> fix spacing.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528218032
PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528217624


More information about the client-libs-dev mailing list