RFR: 8328300: Convert PrintDialogsTest.java from Applet to main program

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Mar 18 09:51:28 UTC 2024


On Fri, 15 Mar 2024 21:20:04 GMT, Phil Race <prr at openjdk.org> wrote:

> This applet test is converted to a main program using PassFailJFrame.
> Other than that, the main thing I improved is the instructions.

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java line 58:

> 56:         (a) The dialog parent type.
> 57:         (b) The dialog modality type
> 58:         (c) The print dialog type (Print dialog or Page Setup dialog)

Can we put a one line gap in the GUI between Dialog parent type options and next dialog modality type heading...Right now the type and the options of all 3 appear one after the other,,,maybe 1 line gap between each category would help 

![image](https://github.com/openjdk/jdk/assets/43534309/a6c0f3f2-def3-4648-a13c-6e720bf6350c)

-------------

PR Review: https://git.openjdk.org/jdk/pull/18333#pullrequestreview-1942457324
PR Review Comment: https://git.openjdk.org/jdk/pull/18333#discussion_r1528220823


More information about the client-libs-dev mailing list