RFR: 8328035: Convert javax/swing/text/html/TableView/7030332/bug7030332.java applet test to main [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Mar 18 13:30:29 UTC 2024


On Mon, 18 Mar 2024 09:37:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> > > > > I am not sure but to me the images dont seem to match in windows11..it seems JEditorPane image is 1 pixel thicker than golden images...in which case, it needs to be problemlisted Also, I guess this has potential of making it automated by loading the golden images and JEditorPane in BufferedImage and then compare...
> > > > > ![image](https://private-user-images.githubusercontent.com/43534309/313576442-c9b84f20-5b0c-44f2-a9a8-c5568d1b0ef4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTM2MTEsIm5iZiI6MTcxMDc1MzMxMSwicGF0aCI6Ii80MzUzNDMwOS8zMTM1NzY0NDItYzliODRmMjAtNWIwYy00NGYyLWE5YTgtYzU1NjhkMWIwZWY0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MTUxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2NjJmNzRmMzBjMzUyMzUxOWRiODBmZGJmNGU5Zjc4NThmMTUwZjc4NWJkN2NhYWI0ZmE4YWJkYmZkYTg3YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c3EEHxT_VGBlWLLQkH4xIdbcXBBuvpYoNW3KQfZNgAw)
> > > > 
> > > > 
> > > > You mean to say the border of JEditorPane is 1 pixel thicker ?
> > > 
> > > 
> > > it doesn't look exactly same subjectively...
> > > ![image](https://private-user-images.githubusercontent.com/43534309/313618601-15dcdcab-fdf4-4bf4-8ef8-7c0689d6b538.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTA3NTQyNDIsIm5iZiI6MTcxMDc1Mzk0MiwicGF0aCI6Ii80MzUzNDMwOS8zMTM2MTg2MDEtMTVkY2RjYWItZmRmNC00YmY0LThlZjgtN2MwNjg5ZDZiNTM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzE4VDA5MjU0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3NmZmMGZhNDUyYzM2Y2UyNGExN2QyZjFiNjljZDljMTE2NDdiMmM4NzIwYzgzOTdjYWJmZGY5ZDdjOTkwMTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.d_TI9VegwGDfOcO0zHhgHhxtOHRiTZudNBS0IXIIGhI)
> > 
> > 
> > Yeah, but in instructions they say it should look similar, so wasn't sure whether to problem list or proceed with conversion. You think we should problem list?
> 
> I am not sure...I think there was some fix regarding border stroke sometime back either by @honkar-jdk or @DamonGuy . Maybe expectation should be somewhat different now in which case, probably the instructions should be amended accordingly...Let them verify once..

or maybe run the test with uiScale 1.0 as I believe the golden images are generated without any scaling and windows has default 1.25/1.5 scaling

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003905130


More information about the client-libs-dev mailing list