RFR: JDK-8328299 : Convert DnDFileGroupDescriptor.html applet test to main [v2]

Harshitha Onkar honkar at openjdk.org
Mon Mar 18 18:36:28 UTC 2024


On Mon, 18 Mar 2024 06:04:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> test/jdk/ProblemList.txt line 788:
>> 
>>> 786: java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031 generic-all
>>> 787: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378 generic-all
>>> 788: java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java 8080185 macosx-all,linux-all
>> 
>> @prsadhuk While looking into the test history I noticed you had previous worked on it PR https://github.com/openjdk/jdk/pull/3406, it wasn't integrated though. Any thoughts whether to make this test windows-only or extend the test to other platforms ?
>> 
>> Your previous PR description sounds correct, when I went through the related test bugs it seemed like the test was created for windows-only issue.
>
> The reason it was not integrated was because of this [comment](https://github.com/openjdk/jdk/pull/3406#pullrequestreview-632106612) wherein it was mentioned to update the test to run without MSOutlook dependancy so that it could be run on all platforms so making it not platform dependant..

@prsadhuk When I read it for the 2nd time it makes sense why the @requires check was added. Since it is a manual test there is no way of knowing it has been problem-listed on macOS & linux unless someone explicitly checks the problemlist before running the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18335#discussion_r1529061835


More information about the client-libs-dev mailing list