RFR: JDK-8328012 : Convert InputMethod (/java/awt/im) applet tests to main [v5]

Harshitha Onkar honkar at openjdk.org
Tue Mar 19 00:54:26 UTC 2024


On Mon, 18 Mar 2024 07:09:33 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review updates
>
> test/jdk/java/awt/im/PinyinIMCommaTest.java line 67:
> 
>> 65:         if (OSInfo.getOSType() != OSInfo.OSType.MACOSX) {
>> 66:             throw new SkippedException("This test is for macOS only");
>> 67:         }
> 
> Is it required to have this SkippedException?
> 
> I guess this test already have jtreg tag @requires("mac") and the test needs to be run with jtreg since we are using PassFailJFrame so I think it's redundant to have this check again in test.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1529534777


More information about the client-libs-dev mailing list