RFR: 8328378: Convert java/awt/FileDialog/FileDialogForDirectories test to main

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Mar 19 07:52:20 UTC 2024


On Mon, 18 Mar 2024 18:16:08 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Convert test to main manual and move to the appropriate folder
> Remove old files

test/jdk/java/awt/FileDialog/FileDialogForDirectories.java line 36:

> 34:  * @test
> 35:  * @bug 7161437
> 36:  * @summary We should support "apple.awt.fileDialogForDirectories" property.

@library is missing...Does it work for you without this? I see most of your latest PRs doesn't have this tag

test/jdk/java/awt/FileDialog/FileDialogForDirectories.java line 43:

> 41: public class FileDialogForDirectories {
> 42:     private static Button showBtn;
> 43:     private static FileDialog fd;

Can be made local in main

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18358#discussion_r1529879913
PR Review Comment: https://git.openjdk.org/jdk/pull/18358#discussion_r1529880137


More information about the client-libs-dev mailing list