RFR: 8328401: Convert java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.html applet test to automated

Abhishek Kumar abhiscxk at openjdk.org
Tue Mar 19 12:25:22 UTC 2024


On Mon, 18 Mar 2024 23:46:34 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> The test converted to automated, CI and manual testing looks good on all platforms.

test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 55:

> 53:             EventQueue.invokeAndWait(InitialMaximizedTest::createAndShowFrame);
> 54:             robot.waitForIdle();
> 55:             robot.delay(2000);

delay is too long ? Generally we have 1000 ms delay after creating test UI.

test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 81:

> 79:         System.out.println("GraphicsConfiguration bounds " + gc.getBounds());
> 80:         System.out.println("Screen insets: " + screenInsets);
> 81:         System.out.println("Work area: " + workArea);

Is it intentional to keep so many print statement?

test/jdk/java/awt/Frame/InitialMaximizedTest/InitialMaximizedTest.java line 94:

> 92:         frame.setLocation(50, 50);
> 93:         frame.setExtendedState(Frame.MAXIMIZED_BOTH);
> 94:         frame.addWindowListener(new WindowAdapter() {

Suggestion:
May be replaced with 
`frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530251566
PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530253414
PR Review Comment: https://git.openjdk.org/jdk/pull/18367#discussion_r1530259495


More information about the client-libs-dev mailing list