RFR: 8328328: Convert javax/swing/JTabbedPane/4666224/bug4666224.java applet test to main [v2]

Abhishek Kumar abhiscxk at openjdk.org
Wed Mar 20 08:22:20 UTC 2024


On Wed, 20 Mar 2024 06:01:25 GMT, Tejesh R <tr at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor fix
>
> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 54:
> 
>> 52:                 ON ALL PLATFORMS
>> 53:                     1. Click on any of the tabs, focus indicator is visible.
>> 54:                     2. Lose focus on the window by clicking on some other window.
> 
> Lose focus?

Yeah, it means the current focused windows should not be focused.

> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 132:
> 
>> 130:         map.put("bottom", new RotateAction(JTabbedPane.BOTTOM));
>> 131:         map.put("changeLayout", new ChangeLayoutAction());
>> 132:         map.put("dump", new DumpAction());
> 
> `DumpAction `can also be mentioned in INSTRUCTIONS I guess, since its been used here.

There is no instruction mentioned in old applet test. Kept it as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531660249
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531660927


More information about the client-libs-dev mailing list