RFR: 8328185: Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to main [v3]
Damon Nguyen
dnguyen at openjdk.org
Wed Mar 20 16:19:34 UTC 2024
On Tue, 19 Mar 2024 23:36:31 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review changes
>
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 27:
>
>> 25: * @bug 4078566 6658398
>> 26: * @library /java/awt/regtesthelpers
>> 27: * @build PassFailJFrame
>
> How about we add @requires os.family == "linux" additionally here?
Added
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 29:
>
>> 27: * @build PassFailJFrame
>> 28: * @summary Test for a memory leak in Image.
>> 29: * @run main MemoryLeakTest
>
> missing manual here
Fixed
> test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 42:
>
>> 40: private static final String INSTRUCTIONS =
>> 41: """
>> 42: Do the following steps on Solaris only.
>
> Since the test can be run on Unix platforms, how about including it in the instructions.
> Suggestion:
>
> Do the following steps on Unix platforms.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1532394025
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1532393776
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1532393605
More information about the client-libs-dev
mailing list