RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v2]

Damon Nguyen dnguyen at openjdk.org
Wed Mar 20 16:34:21 UTC 2024


On Tue, 19 Mar 2024 21:07:44 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instructions updated

Do we need to add any instructions regarding the blue "empty" boxes that appear?

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 53:

> 51:                 On the systems that supports pictured drag, the image under the drag-cursor
> 52:                 should appear.
> 53:                 "Image under drag-cursor" is a translucent blue rectangle + red circle

Suggestion:

                On the systems that supports pictured drag, the image under the 
                drag-cursor should appear.
                "Image under drag-cursor" is a translucent blue rectangle + red circle


In the instructions window, there's an extra newline due to exceeding the character limit per line.

-------------

Changes requested by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18315#pullrequestreview-1949433569
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532417383


More information about the client-libs-dev mailing list