RFR: 8328238: Convert few closed manual applet tests to main [v3]

Alexey Ivanov aivanov at openjdk.org
Wed Mar 20 16:38:23 UTC 2024


On Wed, 20 Mar 2024 10:18:43 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spacing

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JFrame/bug4419914.java line 71:

> 69:         frame.enableInputMethods(false);
> 70:         frame.getContentPane().setComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT);
> 71:         frame.getContentPane().setLocale(new Locale("en"));

Suggestion:

        frame.getContentPane().setLocale(Locale.ENGLISH);

test/jdk/javax/swing/text/PaintTest.java line 83:

> 81:                     if (getFont() != null) {
> 82:                         size.height += getFontMetrics(getFont()).
> 83:                                        getHeight() / 2;

Suggestion:

                        size.height += getFontMetrics(getFont())
                                       .getHeight() / 2;

Wrap the `.` operator to the next line.

test/jdk/javax/swing/text/html/StyleSheet/bug4803145.java line 81:

> 79:         jep.setText(text);
> 80: 
> 81:         f.setSize(500,500);

Suggestion:

        f.setSize(500, 500);

-------------

PR Review: https://git.openjdk.org/jdk/pull/18390#pullrequestreview-1949432377
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1532416576
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1532422176
PR Review Comment: https://git.openjdk.org/jdk/pull/18390#discussion_r1532425463


More information about the client-libs-dev mailing list