RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v2]

Alexey Ivanov aivanov at openjdk.org
Wed Mar 20 17:13:34 UTC 2024


On Tue, 19 Mar 2024 21:07:44 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   instructions updated

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 46:

> 44: 
> 45:             1. Click on the button and drag to the red panel by pressing
> 46:                the "CTRL" key on the keyboard.

Suggestion:

            1. Click on the button and drag it to the red panel while holding
               the "CTRL" key on the keyboard.

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 59:

> 57:                 On Windows system the image under cursor would be visible ONLY over
> 58:                 the drop targets with activated extended OLE D'n'D support (that are,
> 59:                 the desktop and IE).

Suggestion:

                On Windows, the image under the cursor would be visible ONLY over
                drop targets with activated extended D'n'D support. It means the image
                may not be displayed when dragging over some windows, it is not error. The
                image should be display when dragging over the red/yellow panel.

Let's clarify the instructions a bit.

test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 65:

> 63:                 The panel should turn red again and a yellow button labeled ,
> 64:                 "Drag ME!" should appear inside the panel. You should be able,
> 65:                 to repeat this operation multiple times.

Suggestion:

                The panel should turn red again and a yellow button labeled
                "Drag ME!" should appear inside the panel. You should be able
                to repeat this operation multiple times.

No comma here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18315#pullrequestreview-1949533848
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532478358
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532484264
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532486266


More information about the client-libs-dev mailing list