RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

Damon Nguyen dnguyen at openjdk.org
Wed Mar 20 17:26:21 UTC 2024


On Wed, 20 Mar 2024 16:07:50 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main method based;
>> Move test to an apropriate location;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved test metadate closer to the class definition;
>   Made variables local;
>   Made test skip execution on an unsupported toolkit;

Changes requested by dnguyen (Committer).

test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 46:

> 44:  * @library /test/lib
> 45:  * @build PassFailJFrame
> 46:  * @build jtreg.SkippedException

Suggestion:

 * @library /java/awt/regtesthelpers /test/lib
 * @build PassFailJFrame jtreg.SkippedException


Not positive if this is correct, but I was able to combine the `@library` and `@build` on one line by adding a space between the two.

test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 47:

> 45:  * @build PassFailJFrame
> 46:  * @build jtreg.SkippedException
> 47:  * @run main/manual FileDialogReturnTest.html

This still runs on the `.html` file. Does this run correctly for you when testing?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18363#pullrequestreview-1949578878
PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1532505591
PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1532509430


More information about the client-libs-dev mailing list