RFR: JDK-8328225: Convert ImageDecoratedDnD.html applet test to main [v4]
Alexey Ivanov
aivanov at openjdk.org
Wed Mar 20 17:32:54 UTC 2024
On Wed, 20 Mar 2024 17:29:58 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> Following test is converted to main using PassFailJFrame.
>
> Harshitha Onkar has updated the pull request incrementally with three additional commits since the last revision:
>
> - frame.setSize() used
> - review update
> - review update
Marked as reviewed by aivanov (Reviewer).
test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 34:
> 32: * @test
> 33: * @bug 4874070
> 34: * @summary Tests CTRL + DnD functionality.
I think summaries look better without the full stop in the end…
test/jdk/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java line 62:
> 60: It means the image may not be displayed when dragging over some
> 61: windows, it is not error.
> 62: The image should be display when dragging over the red/yellow panel.
Suggestion:
windows, it is not an error.
The image should be displayed when dragging over the red/yellow panel.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18315#pullrequestreview-1949594651
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532516400
PR Review Comment: https://git.openjdk.org/jdk/pull/18315#discussion_r1532515526
More information about the client-libs-dev
mailing list