RFR: 8328385: Convert java/awt/FileDialog/FileDialogReturnTest test to main [v3]

Alexander Zuev kizune at openjdk.org
Wed Mar 20 18:37:45 UTC 2024


On Wed, 20 Mar 2024 17:21:13 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Moved test metadate closer to the class definition;
>>   Made variables local;
>>   Made test skip execution on an unsupported toolkit;
>
> test/jdk/java/awt/FileDialog/FileDialogReturnTest.java line 46:
> 
>> 44:  * @library /test/lib
>> 45:  * @build PassFailJFrame
>> 46:  * @build jtreg.SkippedException
> 
> Suggestion:
> 
>  * @library /java/awt/regtesthelpers /test/lib
>  * @build PassFailJFrame jtreg.SkippedException
> 
> 
> Not positive if this is correct, but I was able to combine the `@library` and `@build` on one line by adding a space between the two.

I prefer to use separate lines just to make it more readable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18363#discussion_r1532605591


More information about the client-libs-dev mailing list