RFR: 8328560: java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java imports Applet [v2]

[Phil Race]

On Wed, 20 Mar 2024 17:39:56 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328560
>
> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 45:
> 
>> 43: 
>> 44: public class ClickDuringKeypress implements MouseListener {
>> 45:    //Declare things used in the test, like buttons and labels here
> 
> Comments can be removed.

I thought about it already, seemed harmless, but I can remove it.

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 67:
> 
>> 65:            doTest();
>> 66:        } finally {
>> 67:            if (frame != null) {
> 
> null check should be done on EDT ?

Not needed for the null check

> test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java line 88:
> 
>> 86:        robot.delay(1000);
>> 87:        if (!ready) {
>> 88:            System.out.println("Not Activated. Test fails");
> 
> Looks redundant.

good to log, so I think it should stay

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533047044
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533046679
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1533048055