RFR: 8328540: test javax/swing/JSplitPane/4885629/bug4885629.java fails on windows hidpi [v2]

[Prasanta Sadhukhan]

On Wed, 20 Mar 2024 17:38:44 GMT, Phil Race <prr at openjdk.org> wrote:

>> A simple fix to the test to skip sampling the leftmost and rightmost ends of the divider
>> to avoid possible issues at fractional scales.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328540

Marked as reviewed by psadhukhan (Reviewer).

test/jdk/javax/swing/JSplitPane/4885629/bug4885629.java line 109:

> 107:                     for (int i = 1; i < rect.width - 1; i++) {
> 108:                         if (!BGCOLOR.equals(robot.getPixelColor(p.x + i, p.y + rect.height - 1))) {
> 109:                             throw new Error("The divider's area has incorrect color. i=" + i);

Should we still use "Error" or use RuntimeException for consistency with other tests?

-------------

PR Review: https://git.openjdk.org/jdk/pull/18384#pullrequestreview-1950781009
PR Review Comment: https://git.openjdk.org/jdk/pull/18384#discussion_r1533262146