RFR: 8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main

Tejesh R tr at openjdk.org
Thu Mar 21 10:39:23 UTC 2024


On Wed, 20 Mar 2024 03:09:32 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Test converted to main.
> Instructions split to Windows and Linux, with some clarifications.
> The test runs successfully on Windows and Linux.

Marked as reviewed by tr (Committer).

test/jdk/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java line 25:

> 23: 
> 24: 
> 25: import jdk.test.lib.Platform;

Minor one - Additional line space before imports can be removed.

test/jdk/java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java line 39:

> 37:  * @build PassFailJFrame jdk.test.lib.Platform
> 38:  * @run main/manual DiacriticsTest
> 39: */

Another minor observation - One space before asterisk. 
Else it looks good to me.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18388#pullrequestreview-1951695172
PR Review Comment: https://git.openjdk.org/jdk/pull/18388#discussion_r1533618831
PR Review Comment: https://git.openjdk.org/jdk/pull/18388#discussion_r1533619460


More information about the client-libs-dev mailing list