RFR: 8328570: Convert closed JViewport manual applet tests to main [v2]

Abhishek Kumar abhiscxk at openjdk.org
Thu Mar 21 11:14:21 UTC 2024


On Thu, 21 Mar 2024 08:57:57 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Few closed manual applet JViewport tests are converted to main based and opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   getCOntentPane removed

Minor suggestion

test/jdk/javax/swing/JViewport/bug4137282.java line 32:

> 30:  * @build PassFailJFrame
> 31:  * @run main/manual bug4137282
> 32: */

Suggestion:

 */

test/jdk/javax/swing/JViewport/bug4217252.java line 31:

> 29:  * @build PassFailJFrame
> 30:  * @run main/manual bug4217252
> 31: */

Suggestion:

 */

test/jdk/javax/swing/JViewport/bug4243479.java line 31:

> 29:  * @build PassFailJFrame
> 30:    @run main/manual bug4243479
> 31: */

Suggestion:

 */

test/jdk/javax/swing/JViewport/bug4750421.java line 31:

> 29:  * @build PassFailJFrame
> 30:  * @run main/manual bug4750421
> 31: */

Suggestion:

 */

-------------

Marked as reviewed by abhiscxk (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18418#pullrequestreview-1951827393
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1533670823
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1533672019
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1533674332
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1533674808


More information about the client-libs-dev mailing list