RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2]

Alexey Ivanov aivanov at openjdk.org
Thu Mar 21 12:02:23 UTC 2024


On Fri, 15 Mar 2024 15:00:40 GMT, Joel Uckelman <duke at openjdk.org> wrote:

>> So, changing the condition in the `if`-block from `special1 || special2` to `special1 && special2` makes the sorting order consistent because the relation is now *transitive*:
>> 
>> 
>> a < b & b < c therefore a < c
>
> Hi, I'm the submitter of the original bug report. I can confirm that you got the reason for the change exactly right.

Thank you, @uckelman, for the detailed analysis. Greatly appreciated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18126#discussion_r1533761341


More information about the client-libs-dev mailing list