RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

Alexander Zvegintsev azvegint at openjdk.org
Thu Mar 21 13:19:20 UTC 2024


On Thu, 21 Mar 2024 11:56:46 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>>> I wonder if it's the default focus owner? 
>> 
>> It is(e.g. with `setFocusPainted(true)`):
>> ![image](https://github.com/openjdk/jdk/assets/77687766/b47e9011-c47d-437d-b9b0-0e4ac88a5c6f)
>> 
>>> Should we request focus to Pass instead?
>> 
>> Probably not, to avoid accidentally passing the test, while hitting the pause is harmless.
>
> Not so sure… Pause is not the main control. I guess the focus was in the instructions previously, we could preserve it. It may be not worth it though.

It's not clear why we need a focus on the field with instructions.
The focus on the pause button makes sense:
Suppose someone is running many, many tests and decides to take a tea break, he just presses the space bar without moving the mouse.
(if he knows  that the focus is on the pause button, `setFocusPainted(false)` :-) )

Anyway, if this bothers anyone we can come back to it later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1533887869


More information about the client-libs-dev mailing list