RFR: 8328673: Convert closed text/html/CSS manual applet test to main [v2]

Thu Mar 21 14:41:52 UTC 2024

On Thu, 21 Mar 2024 14:00:17 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   library path fix
>
> test/jdk/javax/swing/text/html/CSS/bug4271058.java line 60:
> 
>> 58:                 .columns(30)
>> 59:                 .testUI(bug4271058::createTestUI)
>> 60:                 .build()
> 
> I guess the test will benefit from a screenshot feature to capture how the table is rendered.
> Suggestion:
> 
>                 .testUI(bug4271058::createTestUI)
>                 .screenCapture()
>                 .build()
> 
> 
> The feature to take a screenshot automatically, when Fail button is pressed, hasn't been implemented yet. It's tracked under [JDK-8317114](https://bugs.openjdk.org/browse/JDK-8317114).

ok

> test/jdk/javax/swing/text/html/CSS/bug4286458.java line 57:
> 
>> 55: 
>> 56:         String text =
>> 57:             "</html><body><table border=\"1\" cellpadding=\"-10\">" +
> 
> Suggestion:
> 
>             "<html><body><table border="1" cellpadding="-10">" +
> 
> It should start with an opening tag.

yes

> test/jdk/javax/swing/text/html/CSS/bug4286458.java line 65:
> 
>> 63:         jep.setEditorKit(new HTMLEditorKit());
>> 64:         jep.setEditable(false);
>> 65:         jep.setText(text);
> 
> Suggestion:
> 
>         JEditorPane jep = new JEditorPane("text/html", text);
>         jep.setEditable(false);
> 
> Could be reduced to.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1534048754
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1534049280
PR Review Comment: https://git.openjdk.org/jdk/pull/18424#discussion_r1534048927