RFR: 8328570: Convert closed JViewport manual applet tests to main [v3]

[Prasanta Sadhukhan]

On Thu, 21 Mar 2024 14:40:30 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   formatting
>
> test/jdk/javax/swing/JViewport/bug4137282.java line 86:
> 
>> 84:     }
>> 85: 
>> 86:     static void setPaneSize(int w, int h) {
> 
> Do we even need this method? It is used twice and if we just do setSize and setPreferredSize in these two places we could drop this method and make panel variable local. That will make it more compact and in my opinion more readable.

Yes, I considered that but it has 2 lines and used in 2 places...if it had been 1 line I would have done it but since it was more than 1 line I kept it and I dont think its affecting readability so much, is it?

> test/jdk/javax/swing/JViewport/bug4243479.java line 30:
> 
>> 28:  * @library /java/awt/regtesthelpers
>> 29:  * @build PassFailJFrame
>> 30:    @run main/manual bug4243479
> 
> Suggestion:
> 
>  * @run main/manual bug4243479

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1534057018
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1534053111