RFR: 8328382: Convert java/awt/FileDialog/FileDialogForPackages test to main [v2]

[Prasanta Sadhukhan]

On Tue, 19 Mar 2024 14:10:52 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Convert test to a main based;
>> Move test to an appropriate folder;
>> Remove old files;
>
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding library and build clauses

test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59:

> 57:         frame.add(textScrollPane, BorderLayout.CENTER);
> 58: 
> 59:         fd = new FileDialog(new Frame(), "Open");

is there any need to mix Swing and AWT components in the test? I guess you can use the JFrame already created

test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 60:

> 58: 
> 59:         fd = new FileDialog(new Frame(), "Open");
> 60:         fd.setDirectory(APPLICATIONS_FOLDER);

guess APPLICATION_FOLDER can be made local

test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 91:

> 89:                 .rows((int) instructions.lines().count() + 1)
> 90:                 .columns(40)
> 91:                 .testUI(FileDialogForPackages::initialize)

It seems the filedialog is obscuring the instruction and test window...I guess it will be good if you can use 
position(PassFailJFrame.Position.TOP_LEFT_CORNER)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1534230960
PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1534230082
PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1534232128