RFR: 8328368: Convert java/awt/image/multiresolution/MultiDisplayTest/MultiDisplayTest.java applet test to main [v2]

Damon Nguyen dnguyen at openjdk.org
Thu Mar 21 17:23:35 UTC 2024


On Thu, 21 Mar 2024 17:03:41 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 109:
> 
>> 107:         frame = new JFrame("MultiDisplayTest");
>> 108:         frame.setLayout(new BorderLayout());
>> 109:         Button b = new Button("Start");
> 
> Just noticed that the `frame` is not used in test itself, so I guess we can get rid of it, and make this method return the "Start" `JButton`, and use it with `splitUIBottom`/`splitUIRight` instead of `testUI`

Good point. I Removed the `frame`. Changed `button` to `JButton`. Did everything else accordingly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534331937


More information about the client-libs-dev mailing list