RFR: 8328301: Convert Applet test ManualHTMLDataFlavorTest.java to main program [v2]
Phil Race
prr at openjdk.org
Thu Mar 21 17:59:21 UTC 2024
On Thu, 21 Mar 2024 15:14:26 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8328301
>
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 110:
>
>> 108: } catch (UnsupportedFlavorException | IOException e) {
>> 109: e.printStackTrace();
>> 110: }
>
> Should exception make the test fail?
The author of the test didn't think so, this doesn't seem related to converting to a main program
so I don't want to touch it.
> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java line 123:
>
>> 121: the browser to other applications because of,
>> 122: the protected mode restrictions.,
>> 123: On Mac OS X do NOT use Safari, it does not provide the needed DataFlavor,
>
> Suggestion:
>
> IMPORTANT NOTE: the page should be stored locally.
> Otherwise, for instance iexplore, can prohibit drag and drop from
> the browser to other applications because of
> the protected mode restrictions.
> On Mac OS X do NOT use Safari, it does not provide the needed DataFlavor.
>
> The commas in the end of each line seem to come from the commas separating items in an array of Strings. I'm for removing those commas to avoid any confusion when reading the instructions.
yes, they are. I will fix this and tidy up the text a little bit more.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534383187
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1534378391
More information about the client-libs-dev
mailing list