RFR: JDK-8328190 : Convert AWTPanelSmoothWheel.html applet test to main [v6]

Harshitha Onkar honkar at openjdk.org
Thu Mar 21 19:53:49 UTC 2024


On Thu, 21 Mar 2024 15:04:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added preciseWheelRotation logic & updated test
>
> test/jdk/java/awt/event/MouseEvent/AWTPanelSmoothWheel.java line 99:
> 
>> 97:                 }
>> 98:                 if (wheelEventCount >= 5 && hiResWheelCount == 0) {
>> 99:                     PassFailJFrame.log("WARNING !!! You might not be using a high-res mouse.");
> 
> [`JOptionPane.showMessageDialog`](https://docs.oracle.com/en/java/javase/21/docs/api/java.desktop/javax/swing/JOptionPane.html#showMessageDialog(java.awt.Component,java.lang.Object,java.lang.String,int)) could be a better option to attract the tester's attention.

Thanks for the suggestion. Added it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18312#discussion_r1534577098


More information about the client-libs-dev mailing list