RFR: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main [v2]

Phil Race prr at openjdk.org
Thu Mar 21 20:10:42 UTC 2024


On Thu, 21 Mar 2024 13:51:16 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8328642
>
> test/jdk/java/awt/List/MouseDraggedOutCauseScrollingTest/MouseDraggedOutCauseScrollingTest.java line 31:
> 
>> 29:   @library /java/awt/regtesthelpers
>> 30:   @run main/manual MouseDraggedOutCauseScrollingTest
>> 31: */
> 
> We usually move this and instructions block closer to a class declaration, for better readability.

So people have been saying this, and I've even done it when asked, but I'm not sure I agree.
Although it has to go below the legal stuff, after that I like to see the test tag right at the top of the file,
not below a random number of imports.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18414#discussion_r1534605049


More information about the client-libs-dev mailing list