RFR: 8328380: Remove applet usage from JColorChooser tests Test6348456

Harshitha Onkar honkar at openjdk.org
Fri Mar 22 01:34:25 UTC 2024


On Mon, 18 Mar 2024 20:07:50 GMT, Alisen Chung <achung at openjdk.org> wrote:

> Removing applet usage from manual JColorChooser tests

Marked as reviewed by honkar (Reviewer).

test/jdk/javax/swing/JColorChooser/Test6348456.java line 45:

> 43: 
> 44:     private static final DefaultColorSelectionModel WHITE = new DefaultColorSelectionModel(Color.WHITE);
> 45:     private static final DefaultColorSelectionModel BLACK = new DefaultColorSelectionModel(Color.BLACK);

Please fix line-lengths.

test/jdk/javax/swing/JColorChooser/Test6348456.java line 66:

> 64: 
> 65:     public static JFrame test() {
> 66:         JFrame frame = new JFrame("temp");

@alisenchung JFrame title can be changed to more appropriate name.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18359#pullrequestreview-1953779270
PR Review Comment: https://git.openjdk.org/jdk/pull/18359#discussion_r1534930688
PR Review Comment: https://git.openjdk.org/jdk/pull/18359#discussion_r1534931780


More information about the client-libs-dev mailing list