RFR: 8316324: Opensource five miscellaneous Swing tests
Prasanta Sadhukhan
psadhukhan at openjdk.org
Fri Mar 22 07:16:22 UTC 2024
On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:
> Clean up and opensource five tests.
test/jdk/javax/swing/InputVerifier/bug4774166.java line 44:
> 42: * @summary InputVerifier should be called after a window loses and then regains focus
> 43: * @library /javax/swing/regtesthelpers
> 44: * @build JRobot
I guess JRobot library dependancy is not needed unnecessarliy, could be achieved by normal Robot in this test..
test/jdk/javax/swing/JButton/4385611/bug4385611.java line 42:
> 40: public class bug4385611 {
> 41: static JButton bt1, bt2;
> 42: static final ImageIcon icon32x32 = new ImageIcon(bug4385611.class.getResource("red.gif"));
did you verify if we are allowed to keep this red.gif in open source as per the image license? Can we not create the Imageicon from a yellow32x32 bufferedimage?
test/jdk/javax/swing/plaf/motif/bug4150591.java line 40:
> 38: public class bug4150591 {
> 39: public static void main(String[] args) {
> 40: MotifInternalFrameTitlePane mtp = new MotifInternalFrameTitlePane(new JInternalFrame());
Is this test required to be added now with motif being deprecated?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535128580
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535132200
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535140010
More information about the client-libs-dev
mailing list