RFR: 8316324: Opensource five miscellaneous Swing tests

[Tejesh R]

On Thu, 21 Mar 2024 23:35:58 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> Clean up and opensource five tests.

test/jdk/javax/swing/InputVerifier/bug4774166.java line 144:

> 142:     public void performTest() throws InterruptedException, InvocationTargetException {
> 143:         robot.setAutoDelay(100);
> 144:         robot.delay(2000);

After setting auto delay, I don't think delay is required here?

test/jdk/javax/swing/InputVerifier/bug4774166.java line 165:

> 163:         robot.hitKey(KeyEvent.VK_M);
> 164:         robot.hitKey(KeyEvent.VK_N);
> 165:         robot.hitKey(KeyEvent.VK_O);

WaitForIdle might be used in between a set of key events.......

test/jdk/javax/swing/InputVerifier/bug4774166.java line 229:

> 227:     public void cleanupGUI() {
> 228:         if (testframe != null) {
> 229:             testframe.setVisible(false);

`testframe.setVisible(false);` is required here? Any advantage for setting the visibility to false ? anyhow its been disposed.....

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535257899
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535261674
PR Review Comment: https://git.openjdk.org/jdk/pull/18443#discussion_r1535249268