RFR: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main
Phil Race
prr at openjdk.org
Sat Mar 23 23:41:23 UTC 2024
On Fri, 22 Mar 2024 18:06:59 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame
Marked as reviewed by prr (Reviewer).
test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 49:
> 47: with two buttons: "Page Dialog" and "Print Dialog".
> 48: 1. Make the "Test Frame" active by clicking on title.
> 49: 2. Press "Page Dialog" button and a page dailog should popup.
dailog -> dialog
test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 68:
> 66: .title("PrinterDialogsModalityTest Test Instructions")
> 67: .instructions(INSTRUCTIONS)
> 68: .rows((int) INSTRUCTIONS.lines().count() + 2)
Oh, that's a nice idea. I'd been tweaking by hand.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18461#pullrequestreview-1956449159
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1536708437
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1536708440
More information about the client-libs-dev
mailing list