RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v52]
Julian Waters
jwaters at openjdk.org
Mon Mar 25 06:02:06 UTC 2024
On Fri, 22 Mar 2024 12:27:31 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Revert Formatting in awt_Component.cpp
>> - Revert Formatting in awt_Window.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 1230:
>
>> 1228: jdouble imgY = (jdouble) ((yPixelOrg * 72)/(jdouble) yPixelRes);
>> 1229: jdouble imgWid = (jdouble) ((imgPixelWid * 72)/(jdouble) xPixelRes);
>> 1230: jdouble imgHgt = (jdouble) ((imgPixelHgt * 72)/(jdouble) yPixelRes);
>
> Suggestion:
>
> jdouble imgX = (jdouble)((xPixelOrg * 72)/(jdouble)xPixelRes);
> jdouble imgY = (jdouble)((yPixelOrg * 72)/(jdouble)yPixelRes);
> jdouble imgWid = (jdouble)((imgPixelWid * 72)/(jdouble)xPixelRes);
> jdouble imgHgt = (jdouble)((imgPixelHgt * 72)/(jdouble)yPixelRes);```
I don't think I can commit this as there are 3 backticks at the end there :P
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1537089274
More information about the client-libs-dev
mailing list