RFR: 8328719: Convert java/awt/print/PageFormat/SetOrient.html applet test to main [v2]

Damon Nguyen dnguyen at openjdk.org
Mon Mar 25 20:03:37 UTC 2024


On Sat, 23 Mar 2024 08:16:13 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Damon Nguyen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Move var inside method
>>  - Add error msg. Add print button instead of auto print on exec.
>
> test/jdk/java/awt/print/PageFormat/SetOrient.java line 106:
> 
>> 104:             pjob.print();
>> 105:         } catch (PrinterException e) {
>> 106:             throw new RuntimeException(e.getMessage());
> 
> In other PRs, I guess we do
> 
> 
>  ex.printStackTrace();
>                     String msg = "PrinterException: " + ex.getMessage();
>                     PassFailJFrame.forceFail(msg);

You're right. Changed to align with other PRs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18462#discussion_r1538160918


More information about the client-libs-dev mailing list