RFR: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main [v2]
Harshitha Onkar
honkar at openjdk.org
Mon Mar 25 22:49:22 UTC 2024
On Mon, 25 Mar 2024 19:53:54 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
>> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix spelling
@DamonGuy The test in https://github.com/openjdk/jdk/pull/18362 and the one in this PR test similar functionality -Dialog Modality when using Print functions. Will combining or retaining only one test make more sense instead of 2 separate tests?
test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 92:
> 90: frame.add(print);
> 91: frame.pack();
> 92: frame.setVisible(true);
frame.setVisible(true); not required when using PassFailJFrame.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18461#issuecomment-2019049516
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538329544
More information about the client-libs-dev
mailing list