RFR: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main [v2]
Harshitha Onkar
honkar at openjdk.org
Tue Mar 26 00:17:26 UTC 2024
On Mon, 25 Mar 2024 23:48:14 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:
> > @DamonGuy The test in #18362 and the one in this PR test similar functionality -Dialog Modality when using Print functions. Will combining or retaining only one test make more sense instead of 2 separate tests?
>
> Good point. This one was originally for windows only for print dialog and page dialog modality. The other PR was for web dialogs. They're also in different directories, one for `PrinterJob` and one for `Dialog`. They are similar though now. What do you suggest @honkar-jdk? I prefer this test overall over the other if I had to pick one. Cleaner and more succinct test.
In my opinion PrintModalDialog.java can be removed since it is redundant. I agree this test looks better. If we go ahead with removing PrintModalDialog.java then
- Remove PrintModalDialog.java as part of new PR since it is already integrated.
- This test (PrinterDialogsModalityTest.java) can be extended to all platforms and we no longer need @requires tag.
- Probably update the @bug to include the bug id related to PrintModalDialog.java.
If it is not too much effort then I suggest on deleting the redundant test. @prrace Any suggestions?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18461#issuecomment-2019139803
More information about the client-libs-dev
mailing list