RFR: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F [v5]

[Abhishek Kumar]

On Mon, 11 Mar 2024 13:25:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   separate method to get LAF defined color
>
> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line 186:
> 
>> 184: 
>> 185:         if (id == Region.LABEL && type == ColorType.FOREGROUND
>> 186:                 && (state & SynthConstants.ENABLED) != 0) {
> 
> Doesn't `SynthConstants.DISABLED` need the same treatment?

Yes, I am working on it to fix the disabled case.

> I believe you should be using `labelColor` here. If anyone changes its value from `Color.RED` to anything else, the test will fail but it shouldn't. After all, why allowing configuring the colour in first place.

makes sense, will update it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1538712355
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1538713181