RFR: 8328827: Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main [v4]

Tejesh R tr at openjdk.org
Tue Mar 26 07:47:25 UTC 2024


On Tue, 26 Mar 2024 00:31:40 GMT, Damon Nguyen <dnguyen at openjdk.org> wrote:

>> Convert java/awt/print/PrinterJob/PrinterDialogsModalityTest/PrinterDialogsModalityTest.html applet test to main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove requires tag

Marked as reviewed by tr (Committer).

test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 74:

> 72:     }
> 73: 
> 74:     public static JFrame init() {

Can rename the `init` method. And the changes are good to me.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18461#pullrequestreview-1959535915
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538715965


More information about the client-libs-dev mailing list