RFR: 8328953 : JEditorPane.read throws ChangedCharSetException [v2]

Tue Mar 26 13:18:24 UTC 2024

On Tue, 26 Mar 2024 12:55:53 GMT, rjolly <duke at openjdk.org> wrote:

>> ChangedCharSetException is used to amend the charset during read according to html directives. Currently it causes immediate exit of the method which in turn causes failure to load html documents with charset directives (even if the latter must not change after all). This PR restores the catch operation as it was before the use of try with resources.
>
> rjolly has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8328953 : JEditorPane.read throws ChangedCharSetException

Changes requested by aivanov (Reviewer).

test/jdk/javax/swing/JEditorPane/8328953/EditorPaneCharset.java line 48:

> 46:             "<head>\n" +
> 47:             "    <meta http-equiv=\"Content-Type\" content=\"text/html; charset=
> 48: 			windows-1251\">\n" +

Is it a valid Java syntax? The file does not compile.

I would prefer wrapping at attribute boundary rather than a value of an attribute.

No tabs are allowed in OpenJDK source code, replace with four spaces.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17567#pullrequestreview-1960341309
PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1539207533