RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v3]
Damon Nguyen
dnguyen at openjdk.org
Tue Mar 26 19:02:26 UTC 2024
On Tue, 26 Mar 2024 02:20:35 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> change to automatic test
test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 95:
> 93: fileChooser = new JFileChooser(subDir);
> 94: fileChooser.setControlButtonsAreShown(false);
> 95: frame.getContentPane().add(fileChooser, BorderLayout.CENTER);
Suggestion:
frame.add(fileChooser, BorderLayout.CENTER);
It was brought to my attention in one of my PRs that `getContentPane()` is obsolete as of JDK 1.5. They referenced https://github.com/openjdk/jdk/pull/18390#discussion_r1533017080.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1539938437
More information about the client-libs-dev
mailing list