RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v4]
Harshitha Onkar
honkar at openjdk.org
Tue Mar 26 21:27:21 UTC 2024
On Tue, 26 Mar 2024 21:16:15 GMT, Phil Race <prr at openjdk.org> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>>
>> instruction string change
>
> test/jdk/javax/swing/JColorChooser/Test6977726.java line 42:
>
>> 40: String instructions = """
>> 41: Check that there is a panel with \"Text Preview Panel\" text
>> 42: and with title \"Preview\" in the JColorChooser.""";
>
> (1) You have a whitespace error that needs fixing.
> (2) It is probably worth adding a sentence "Test passes if the panel is as described, test fails otherwise".
@alisenchung Since you are using string block there is no need to escape double-quotes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1540129111
More information about the client-libs-dev
mailing list