RFR: 8328648: Remove applet usage from JFileChooser tests bug4150029 [v4]

Damon Nguyen dnguyen at openjdk.org
Tue Mar 26 23:43:21 UTC 2024


On Tue, 26 Mar 2024 22:33:45 GMT, Alisen Chung <achung at openjdk.org> wrote:

>> Removing applet usage from manual JFileChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   moved create ui code to helper, change test pass check, add mouse release, remove getContentPane

Changes requested by dnguyen (Committer).

test/jdk/javax/swing/JFileChooser/4150029/bug4150029.java line 121:

> 119:         robot.mouseMove(p.x + 200, p.y + 200);
> 120:         robot.mousePress(InputEvent.BUTTON1_DOWN_MASK);
> 121:         robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK);

`p.x` and `p.y` isn't in scope I believe. You can move `Point p` outside the method, make it static and volatile, then it should be fine. Maybe remove the extra newline in this `SwingUtilities.invokeAndWait()` block as well.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18415#pullrequestreview-1961948241
PR Review Comment: https://git.openjdk.org/jdk/pull/18415#discussion_r1540238433


More information about the client-libs-dev mailing list