RFR: 8320676 : Manual printer tests have no Pass/Fail buttons, instructions close set 1 [v11]

[Alexey Ivanov]

On Tue, 5 Mar 2024 12:22:56 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Suggesions incorporated
>
> test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 69:
> 
>> 67:         if (pj.printDialog()) {
>> 68:             pj.print();
>> 69:         }
> 
> Fail the test if the user clicks Cancel in the print dialog?

I still think the test should fail if the tester clicks Cancel in the print dialog.

> test/jdk/java/awt/print/PrinterJob/ValidatePage/ValidatePage.java line 233:
> 
>> 231:                 "needed to accomodate the imageable area.\n \n \n" +
>> 232:                 "To test 6229507, put the minimum margins (all 0s) in Page Setup dialog.\n" +
>> 233:                 "Compare Imageable width, height, and margins of portrait against landscape.");
> 
> Suggestion:
> 
>                 "When validating a page, the process is 1st to find the closest matching\n" +
>                 "paper size, next to make sure the requested imageable area fits within\n" +
>                 "the printer's imageable area for that paper size. Finally the top and\n" +
>                 "left margins will be shrunk if they are too great for the adjusted\n" +
>                 "imageable area to fit at that position. They will shrink by the minimum\n" +
>                 "needed to accomodate the imageable area.\n\n\n" +
>                 "To test 6229507, put the minimum margins (all 0s) in Page Setup dialog.\n" +
>                 "Compare Imageable width, height, and margins of portrait against landscape.");
> 
> The spaces at the end of lines are redundant.

Spaces at the end of the line can be removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1542061869
PR Review Comment: https://git.openjdk.org/jdk/pull/17607#discussion_r1542066476