RFR: 8328403: Remove applet usage from JColorChooser tests Test6977726 [v5]
Harshitha Onkar
honkar at openjdk.org
Thu Mar 28 00:23:32 UTC 2024
On Tue, 26 Mar 2024 22:29:32 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Removing applet usage from manual JColorChooser tests
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> instruction string change
Changes requested by honkar (Reviewer).
test/jdk/javax/swing/JColorChooser/Test6977726.java line 51:
> 49: .columns(40)
> 50: .testTimeOut(2)
> 51: .splitUIRight(Test6977726::createColorChooser)
To avoid the empty white space in instruction panel, we could use .testUI() instead of .splitUI()
Suggestion:
.testUI(Test6977726::createColorChooser)
test/jdk/javax/swing/JColorChooser/Test6977726.java line 57:
> 55:
> 56: private static JColorChooser createColorChooser() {
> 57: JColorChooser chooser = new JColorChooser();
It is easy to miss the white colored text in Preview Panel. Can we change the default color to blue?
Suggestion:
JColorChooser chooser = new JColorChooser(Color.BLUE);
-------------
PR Review: https://git.openjdk.org/jdk/pull/18369#pullrequestreview-1964958564
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1542174702
PR Review Comment: https://git.openjdk.org/jdk/pull/18369#discussion_r1542174312
More information about the client-libs-dev
mailing list