RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v13]

[Alexey Ivanov]

On Tue, 19 Mar 2024 09:24:35 GMT, Renjith Kannath Pariyangad <rkannathpari at openjdk.org> wrote:

>> Hi Reviewers,
>> 
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused variables. Added 'SkippedException' in case of printer missing or not configured.
>> 
>> Please review and let me know your suggestions.
>> 
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated PassFailJFrame object creation

Changes requested by aivanov (Reviewer).

test/jdk/java/awt/print/PrinterJob/Collate2DPrintingTest.java line 24:

> 22:  */
> 23: 
> 24: import java.awt.Frame;

Suggestion:


`Frame` is no longer used.

test/jdk/java/awt/print/PrinterJob/InvalidPage.java line 25:

> 23: 
> 24: import java.awt.Color;
> 25: import java.awt.Frame;

Suggestion:


Frame is no longer used.

test/jdk/java/awt/print/PrinterJob/JobName/PrinterJobName.java line 51:

> 49:         }
> 50: 
> 51:         PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()

Suggestion:

        PassFailJFrame passFailJFrame = PassFailJFrame.builder()

You have to use the `builder()` method.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17608#pullrequestreview-1969360561
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544773033
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544786464
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544792178