RFR: 8324807 : Manual printer tests have no Pass/Fail buttons, instructions close set 2 [v10]

Alexey Ivanov aivanov at openjdk.org
Fri Mar 29 19:08:34 UTC 2024


On Tue, 5 Mar 2024 13:15:04 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated instruction
>
> test/jdk/java/awt/print/PrinterJob/DrawImage.java line 93:
> 
>> 91:         if (pj.printDialog()) {
>> 92:             pj.print();
>> 93:         }
> 
> Fail the test if the tester clicks Cancel in the print dialog?

I still think the test should fail if Cancel is clicked in the Print dialog.

The test does not provide an option to do it again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1544776413


More information about the client-libs-dev mailing list